GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix isssues arising in merge of descfcn/iosys changes by murrayrm · Pull Request #540 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Feb 11, 2021

Copy link
Copy Markdown
Member

This PR fixes a problem that popped up when merging changes from PR #536 with PR #521 that showed up as test failures in the master branch, as pointed out by @sawyerbfuller in comments in (merged) PR #536.

The issue had to do with some pre-processing that was being done for iosys.py but that left a latent bug that showed up in one of the describing function unit tests (having to do with how the input parameter is processed). While fixing that, I also found a bug in the way that the describing function code called an output processing function, so fixed that at the same time.

We should review and merge this quickly, since the master branch is currently broken.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix isssues arising in merge of descfcn/iosys changes
a586543
sawyerbfuller
sawyerbfuller approved these changes Feb 11, 2021
View reviewed changes
@sawyerbfuller
sawyerbfuller merged commit eb62d80 into python-control:master Feb 11, 2021
@murrayrm
murrayrm deleted the fix_descfcn_iosys_merge branch February 11, 2021 05:44
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.