GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — new dynamics and output functions for statespace and iosystems by sawyerbfuller · Pull Request #558 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Mar 11, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

revised version of #546.

  • makes t argument required following discussion there. not sure yet that this is the best, but I was almost there already so I just submitted this PR.
  • benchmark results in the discussion of that PR that showed that creating a separate callable that skips argument processing had only a small performance advantage, so I decided to leave dynamics as a method.
  • leaves code and usage of _rhs and _out unchanged in iosys. The idea is to leave them as fast internal methods and to have dynamics and output serve as more user-friendly versions where speed is of less importance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sawyerbfuller
added dynamics and output to statespace and iosystems
e99273a
@sawyerbfuller sawyerbfuller mentioned this pull request Mar 11, 2021
new dynamics() and output() methods in StateSpace #546
Closed
sawyerbfuller added 3 commits March 11, 2021 09:17
@sawyerbfuller
add remark in docstring for iosys._rhs and _out that they are intende…
9678bd1
…d for fast evaluation.
@sawyerbfuller
fix to possibly fix pytest errors when using matrix
c0f7d06
@sawyerbfuller
another try at fixing failing unit tests
64d0dde
@coveralls

coveralls commented Mar 11, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 88.872% when pulling 23c4b09 on sawyerbfuller:dynamics2 into 92de12d on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

murrayrm
murrayrm reviewed Mar 12, 2021
View reviewed changes
Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/statesp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/statesp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/tests/statesp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller
fixes/cleanups suggested by @murrayrm
23c4b09
murrayrm
murrayrm approved these changes Mar 13, 2021
View reviewed changes
@murrayrm murrayrm mentioned this pull request Mar 13, 2021
Release 0.8.4 and 0.9.0 sequencing #451
Closed
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 13, 2021
@murrayrm
murrayrm merged commit 22b9953 into python-control:master Mar 19, 2021
@sawyerbfuller sawyerbfuller linked an issue Mar 19, 2021 that may be closed by this pull request
Some way of stepping a system? #83
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Some way of stepping a system?

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawyerbfuller @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.