GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Step info improve jpp by juanodecc · Pull Request #567 · python-control/python-control Conversation
Contributor
This modification improve step_info results: Solve the issue Any plan for step_info to support negative step responses? #337 I try to fullfill pep 8
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
1) System Type 1 - Step response not stationary: G(s)=1/s(s+1) 2) SISO system with under shoot response and positive final value G(s)=(-s+1)/(s²+s+1) 3) Same system that 2) with k=-1 4) example from matlab online help https://www.mathworks.com/help/control/ref/stepinfo.html G(s)=(s²+5s+5)/(s^4+1.65s^3+6.5s+2) with stepinfo output: RiseTime: 3.8456 SettlingTime: 27.9762 SettlingMin: 2.0689 SettlingMax: 2.6873 Overshoot: 7.4915 Undershoot: 0 Peak: 2.6873 PeakTime: 8.0530 5) example from matlab online help https://www.mathworks.com/help/control/ref/stepinfo.html A = [0.68 -0.34; 0.34 0.68]; B = [0.18 -0.05; 0.04 0.11]; C = [0 -1.53; -1.12 -1.10]; D = [0 0; 0.06 -0.37]; sys = StateSpace(A,B,C,D,0.2); examine the response characteristics for the response from the first input to the second output of sys. with stepinfo output: RiseTime: 0.4000 SettlingTime: 2.8000 SettlingMin: -0.6724 SettlingMax: -0.5188 Overshoot: 24.6476 Undershoot: 11.1224 Peak: 0.6724 PeakTime: 1
|
There was an error while loading. Please reload this page.
|
Coverage decreased (-0.03%) to 88.832% when pulling 81ae64f on juanodecc:step_info_improve_jpp into 92de12d on python-control:master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| rise_time: float = np.NaN | ||
| settling_time: float = np.NaN | ||
| settling_min: float = np.NaN | ||
| settling_max: float = np.NaN | ||
| peak_value: float = np.Inf | ||
| peak_time: float = np.Inf | ||
| undershoot: float = np.NaN | ||
| overshoot: float = np.NaN |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The first use of typing in python-control?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
yes, is wrong?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Not at all! Good thing we already ditched Python 2.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| if InfValue < 0.0: | ||
| # RiseTime | ||
| tr_lower_index = (np.where(yout <= RiseTimeLimits[0] * InfValue)[0])[0] | ||
| tr_upper_index = (np.where(yout <= RiseTimeLimits[1] * InfValue)[0])[0] | ||
| # SettlingTime | ||
| for i in reversed(range(T.size - 1)): | ||
| if (-yout[i] <= np.abs(inf_margin)) | (-yout[i] >= np.abs(sup_margin)): | ||
| settling_time = T[i + 1] | ||
| break | ||
| # Overshoot and Undershoot | ||
| overshoot = np.abs(100. * ((-yout).max() - np.abs(InfValue)) / np.abs(InfValue)) | ||
| undershoot = np.abs(100. * (-yout).min() / np.abs(InfValue)) | ||
| else: | ||
| tr_lower_index = (np.where(yout >= RiseTimeLimits[0] * InfValue)[0])[0] | ||
| tr_upper_index = (np.where(yout >= RiseTimeLimits[1] * InfValue)[0])[0] | ||
| # SettlingTime | ||
| for i in reversed(range(T.size - 1)): | ||
| if (yout[i] <= inf_margin) | (yout[i] >= sup_margin): | ||
| settling_time = T[i + 1] | ||
| break | ||
| # Overshoot and Undershoot | ||
| overshoot = np.abs(100. * (yout.max() - InfValue) / InfValue) | ||
| undershoot = np.abs(100. * yout.min() / InfValue) |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this has a lot of duplicate code. Have you considered using a sign variable and the abs() function instead of two completely separate blocks? I think It won't turn out much more convoluted than the current InfValue < 0 part.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
ok
Sorry, something went wrong.
There was an error while loading. Please reload this page.
systems converting to SISO systems from input=0 to output =0 solve problems with non stationary systems doing SteadyStateValue= nan when y_final is inf
|
Other than the MIMO handling (#574), this looks good to me. I'll merge this. Future PRs can improve it further. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
step_info undershoot must be "Undershoot: Percentage of undershoot" step_info problem with non stationary systems response Any plan for step_info to support negative step responses?
There was an error while loading. Please reload this page.