GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — change u == 0 test to avoid py3.8+ syntax warning by murrayrm · Pull Request #580 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Mar 20, 2021

Copy link
Copy Markdown
Member

PR #546 introduced a test of the form u == 0 that generates a SyntaxWarning in Python 3.8+. I changed this to set u to None by default and then check for u is None. A good description of the reason for the warning is here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
change u == 0 test to avoid py3.8+ syntax warning
89dcf3c
@coveralls

coveralls commented Mar 20, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.14% when pulling 89dcf3c on murrayrm:fix_is_py3.8+ into 55d7e2b on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller

sawyerbfuller commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

good catch, thanks. just so easy to write 'is' by accident in such cases, I thought i had gotten it out of my system but I guess not. : )
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller
sawyerbfuller merged commit 992bf0e into python-control:master Mar 20, 2021
@murrayrm
murrayrm deleted the fix_is_py3.8+ branch March 20, 2021 04:00
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.