GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Step info improve jpp by juanodecc · Pull Request #583 · python-control/python-control

Conversation

@juanodecc

@juanodecc juanodecc commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

WIP: @bnavigator check this new feature... I tested it with a mimo system from matlab help online. This new version improve the undershoot calculus. The undershoot ocurr when the value have diferent sign respect the y_final... the system must have inverse response

For discusions:

  1. In the test for MIMO systems, I had to modifie the result of SettlingTimeMin for pass the test, because I think Matlab result is wrong. (the script take max and min after rise time, and this orcurr at Tr = 0)
  2. The Tr calculs have an error of one DT when compute the Tr for digital systems (like mimo system used for testing) because the script compute the Tr with the two points far. (this is easy to implement)

TODO (WIP): make a new function to compute step_info for data from external simulations or stimulations: step_info_data(t,y,y_final)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
juanodecc added 2 commits March 18, 2021 16:25
@juanodecc
new feature and bug fixes:
f7d3db5 
Now can compute the step response characteristics for MIMO systems.
Fix undershoot caculus for sistems with negative response.
@juanodecc
modify the help according to the new characteristics
8d5810f 
and add a working example too, finaly I corrected
 the see also to referring to functions of this library
@bnavigator

bnavigator commented Mar 20, 2021

Copy link
Copy Markdown
Contributor

Your commits have a date from 2 days ago and they are based on an older commit. Please check #577, which is already merged. We essentially did very similar changes. Could you have a look and make further improvements such as the undershoot calculation based on current master please?

You can discard your unit tests and just change the existing references for the undershoot value, if necessary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator added the needs rebase The PR needs a rebase to current master branch label Mar 20, 2021
@juanodecc

juanodecc commented Mar 22, 2021

Copy link
Copy Markdown
Contributor Author

ok, Ill try to solve this problem
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanodecc juanodecc closed this Mar 22, 2021
@bnavigator bnavigator removed the needs rebase The PR needs a rebase to current master branch label Mar 22, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@juanodecc @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.