GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Return a discrete time system with drss() by bnavigator · Pull Request #589 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

Fixes #587

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnavigator added 3 commits March 24, 2021 22:34
@bnavigator
test that rss and drss return strictly_proper, if desired
066d47e
@bnavigator
test that drss returns a discrete time system with undefined time step
98a08b6
@bnavigator
return a discrete time system with drss()
8e3a141
sawyerbfuller
sawyerbfuller reviewed Mar 24, 2021
View reviewed changes
Comment thread control/statesp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
add test to cover _rss_generate (rss and drss) errors on invalid input
e50ce23
@bnavigator
bnavigator marked this pull request as ready for review March 24, 2021 22:01
@coveralls

coveralls commented Mar 24, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 89.274% when pulling e50ce23 on bnavigator:drss-dt into 203cae8 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Mar 25, 2021
View reviewed changes
@bnavigator
bnavigator merged commit 8b900ca into python-control:master Mar 25, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator
bnavigator deleted the drss-dt branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

drss returns system with wrong dt attribute

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.