GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change step_info undershoot percentage calculation by juanodecc · Pull Request #590 · python-control/python-control

Conversation

@juanodecc

@juanodecc juanodecc commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@juanodecc
Solved undershoot value calculus problem.
a95f75f 
Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.
@coveralls

coveralls commented Mar 24, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.221% when pulling 14a92fe on juanodecc:step_info_improve_undershoot into 203cae8 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Mar 24, 2021
View reviewed changes
Comment thread control/timeresp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
juanodecc
juanodecc commented Mar 24, 2021
View reviewed changes

@juanodecc juanodecc left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... now I see

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/timeresp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@juanodecc
Update timeresp.py
95ca297
@juanodecc

juanodecc commented Mar 24, 2021

Copy link
Copy Markdown
Contributor Author

@bnavigator can you check it. Tank
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Mar 25, 2021
View reviewed changes
Comment thread control/tests/timeresp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Mar 25, 2021
View reviewed changes
Comment thread control/tests/timeresp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Mar 25, 2021
View reviewed changes
Comment thread control/timeresp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
Style cleanup
1e3109f
@bnavigator bnavigator changed the title Undershoot value calculus problem. Solved Change step_info undershoot percentage calculation Mar 25, 2021
bnavigator added 2 commits March 25, 2021 01:24
@bnavigator
Update comment for MATLAB reference
11d89b3
@bnavigator
simplify undershoot calculation
14a92fe
@bnavigator
bnavigator force-pushed the step_info_improve_undershoot branch from b957dee to 14a92fe Compare March 25, 2021 00:27
@bnavigator

bnavigator commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

I pushed some style cleanups and a I think I have a cleaner formula for the undershoot. Please check.
juanodecc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Mar 25, 2021
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. removed one array search - > faster - > good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
bnavigator merged commit ce4c2b6 into python-control:master Mar 25, 2021
@bnavigator

bnavigator commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @juanodecc
juanodecc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@juanodecc @coveralls @bnavigator @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.