GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Include InfValue into settling min/max calculation for step_info by bnavigator · Pull Request #600 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

Fixes #598

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnavigator added 2 commits March 30, 2021 16:26
@bnavigator
test more asymptotic step_info
a0a570a
@bnavigator
fix settling min/max for asymptotic systen
6e94302
@bnavigator

bnavigator commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

The flaky markov test failure is really annoying. #588 will fix it. Also, #588 will make a rebase of this one necessary, or vice versa.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanodecc
juanodecc reviewed Mar 30, 2021
View reviewed changes

@juanodecc juanodecc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnavigator
bnavigator commented Mar 30, 2021
View reviewed changes
Comment thread control/tests/timeresp_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
actually use the specified time vector
e06197c
@coveralls

coveralls commented Mar 30, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.274% when pulling e06197c on bnavigator:fix-598 into 8b900ca on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit f1a9860 into python-control:master Apr 1, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator
bnavigator deleted the fix-598 branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@juanodecc juanodecc juanodecc left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

This system broke step_info function test

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @juanodecc @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.