GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix warnings generated by sisotool by roryyorke · Pull Request #608 · python-control/python-control

Conversation

@roryyorke

@roryyorke roryyorke commented Apr 11, 2021

Copy link
Copy Markdown
Contributor

Use recommended canvas.manager.{get,set}_window_title instead of
deprecated canvas.{get,set}_window_title.

Remove redundant marker specification in sisotool rlocus plot.canvas.manager.{get,set}_window_title

Fixes these warnings on master (Python 3.9.2, Matplotlib 3.4.1, python-control 8299ebb):

ontrol/tests/sisotool_test.py::TestSisotool::test_sisotool
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt
control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo
  /home/rory/src/python-control/control/sisotool.py:84: MatplotlibDeprecationWarning: 
  The get_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.get_window_title or GUI-specific methods instead.
    if fig.canvas.get_window_title() != 'Sisotool':

control/tests/sisotool_test.py::TestSisotool::test_sisotool
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt
control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo
  /home/rory/src/python-control/control/sisotool.py:87: MatplotlibDeprecationWarning: 
  The set_window_title function was deprecated in Matplotlib 3.4 and will be removed two minor releases later. Use manager.set_window_title or GUI-specific methods instead.
    fig.canvas.set_window_title('Sisotool')

control/tests/sisotool_test.py::TestSisotool::test_sisotool
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt
control/tests/sisotool_test.py::TestSisotool::test_sisotool_mimo
  /home/rory/src/python-control/control/rlocus.py:180: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence.
    fig.axes[1].plot(

control/tests/sisotool_test.py::TestSisotool::test_sisotool
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect
control/tests/sisotool_test.py::TestSisotool::test_sisotool_tvect_dt
  /home/rory/src/python-control/control/rlocus.py:628: UserWarning: marker is redundantly defined by the 'marker' keyword argument and the fmt string "m." (-> marker='.'). The keyword argument will take precedence.
    ax_rlocus.plot(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@roryyorke
Fix warnings generated by sisotool
7ae6d0a 
Use recommended canvas.manager.{get,set}_window_title instead of
deprecated canvas.{get,set}_window_title.

Remove redundant marker specification in sisotool rlocus plot.
@coveralls

coveralls commented Apr 11, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.448% when pulling 7ae6d0a on roryyorke:rory/sisotool-warnings into 8299ebb on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Apr 11, 2021
View reviewed changes
@bnavigator
bnavigator merged commit 15dc5ce into python-control:master Apr 11, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@roryyorke @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.