GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated rlocus.py to remove warning by sisotool() with rlocus_grid=True by nirjhar-das · Pull Request #616 · python-control/python-control

Conversation

@nirjhar-das

@nirjhar-das nirjhar-das commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

At line 239 in rlocus.py parameter passed to _sgrid_func() has been corrected. It was giving error when calling sisotool() with parameter rlocus_grid=True.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nirjhar-das nirjhar-das closed this Apr 28, 2021
@nirjhar-das nirjhar-das reopened this Apr 28, 2021
@nirjhar-das @bnavigator
Updated rlocus.py to remove warning by sisotool with rlocus_grid=True
1ca4a03 
At line 239 in rlocus.py parameter passed to _sgrid_func() has been corrected. It was giving error when calling sisotool() with parameter rlocus_grid=True.
@bnavigator
bnavigator force-pushed the nirjhar-das-fix-rlocus branch from 6a6ecbb to 1ca4a03 Compare April 29, 2021 11:49
@coveralls

coveralls commented Apr 29, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.476% when pulling 1ca4a03 on nirjhar-das:nirjhar-das-fix-rlocus into a6a5bee on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Thank you @nirjhar-das!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit c21bc69 into python-control:master Apr 29, 2021
@bnavigator bnavigator mentioned this pull request Apr 29, 2021
Cover more of root_locus: dtime and sisotool #617
Merged
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nirjhar-das @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.