GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Various docstring edits + fixed plot legends on cruise control example by billtubbs · Pull Request #643 · python-control/python-control

Conversation

@billtubbs

@billtubbs billtubbs commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
billtubbs added 3 commits July 31, 2021 18:16
@billtubbs
Fixed minor docstring typos
61f8f79
@billtubbs
Alternative array indexing
3960446
@billtubbs
Fixed plot legend entries and layout
dbe24ee
@coveralls

coveralls commented Jul 31, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.923% when pulling cc97f4b on basicmachines:master into da27d35 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@billtubbs

billtubbs commented Aug 1, 2021

Copy link
Copy Markdown
Contributor Author

Oh. I just noticed there's a jupyter notebook version of the cruise control example. I'll have to update that too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

billtubbs added 3 commits August 1, 2021 15:10
@billtubbs
Fixed plot legends
2f5450a
@billtubbs
Modifications to Fig. 4.2
4c8a764
@billtubbs
Second attempt with control-dev kernel
3fd4c28
@billtubbs

billtubbs commented Aug 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Okay, there's something I don't understand about editing a jupyter notebook. After I make the edits and run the notebook locally, the setup.py test is failing (see test results below):

File "/usr/share/miniconda/lib/python3.9/site-packages/jupyter_client/kernelspec.py", line 230, in get_kernel_spec
    raise NoSuchKernel(kernel_name)
jupyter_client.kernelspec.NoSuchKernel: No such kernel named conda-env-control-dev-py
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

murrayrm
murrayrm reviewed Aug 1, 2021
View reviewed changes
Comment thread examples/cruise.ipynb Outdated
"language": "python",
"name": "python3"
"name": "conda-env-control-dev-py"

@murrayrm murrayrm Aug 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work in the test environment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@murrayrm

murrayrm commented Aug 1, 2021

Copy link
Copy Markdown
Member

The problem with Jupyter notebooks is that they inherit information from your local machine. So the problem is probably something like conda-env-control-dev-py is a local environment on your machine but it doesn't exist in the test environment. I marked this line in the code so that you can see where it occurs.

One fix is to edit the Jupyter notebook directly (in a text editor) and change the code you want to fix. Then commit that change and test it locally, throwing out the new version of the notebook that will be created when you run it (but still making sure it works). Push that up to GitHub and it should be OK. One caveat is that this will leave the notebook with the old figures, which may not be what you want.

Alternatively, run the notebook on your local machine and get things working, then go in and manually change the line that said conda-env-control-dev-py to say python3.

billtubbs reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@billtubbs
Fixed env_spec in jupyter notebook
cc97f4b
@murrayrm
murrayrm merged commit 6b7a9c7 into python-control:master Aug 7, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@billtubbs @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.