GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix damp method for discrete time systems with a negative real-valued pole by vincentchoqueuse · Pull Request #647 · python-control/python-control

Conversation

@vincentchoqueuse

@vincentchoqueuse vincentchoqueuse commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

(first pull request on GitHub)

When a discrete time system has a real-valued negative pole, the discrete to continuous conversion using the log function returns nan. Then, the damp method is not able to compute the damping and the wn values.

To avoid this problem, the poles must be cast to complex values (https://numpy.org/doc/stable/reference/generated/numpy.log.html)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vincentchoqueuse
fix the return of the damp method for discrete time systems with a ne…
78b6fc2 
…gative real-valued pole
@coveralls

coveralls commented Aug 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.923% when pulling 140ca08 on vincentchoqueuse:fix_damp_bug_dlti_system into 6b7a9c7 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Aug 17, 2021
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Excellent first PR.

I left some comments, which can be refined before we merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/tests/lti_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator bnavigator linked an issue Aug 17, 2021 that may be closed by this pull request
Result of the damp function for discrete time systems #646
Closed
bnavigator
bnavigator reviewed Aug 17, 2021
View reviewed changes
Comment thread control/lti.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Aug 17, 2021
View reviewed changes
Comment thread control/tests/lti_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Aug 17, 2021
View reviewed changes
Comment thread control/tests/lti_test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vincentchoqueuse
fix PEP8 compliance style and preserve pole type
140ca08
bnavigator
bnavigator approved these changes Aug 18, 2021
View reviewed changes
@bnavigator
bnavigator merged commit 18976c1 into python-control:master Aug 19, 2021
@bnavigator

bnavigator commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vincentchoqueuse

vincentchoqueuse commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for your advices @bnavigator !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Result of the damp function for discrete time systems

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vincentchoqueuse @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.