GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FIX: plot Nyquist frequency correctly in Bode plot in Hz by murrayrm · Pull Request #651 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Sep 6, 2021

Copy link
Copy Markdown
Member

Quick fix for issue #650, using solution from @dc5048.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
FIX: plot Nyquist frequency correctly in Bode plot in Hz
3b90050
@coveralls

coveralls commented Sep 6, 2021

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.923% when pulling 3b90050 on murrayrm:fix_bode_nyquist_hz into 18976c1 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

For reference:

import control
tf1 = control.tf(control.drss(3,1,1))
tf1.dt=0.1
control.bode_plot(tf1, Hz=True)
Before After
pr-651-pre pr-651-post

(Two different random discrete transfer functions)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 5ab0a1c into python-control:master Sep 6, 2021
@bnavigator bnavigator linked an issue Sep 6, 2021 that may be closed by this pull request
Discrete system bode_plot nyquist line does not respect Hz parameter #650
Closed
@bnavigator bnavigator mentioned this pull request Sep 6, 2021
Discrete system bode_plot nyquist line does not respect Hz parameter #650
Closed
@murrayrm
murrayrm deleted the fix_bode_nyquist_hz branch November 27, 2021 18:35
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Discrete system bode_plot nyquist line does not respect Hz parameter

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.