GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fixed prewarp not working in c2d and sample_system, margin docstring improvements by sawyerbfuller · Pull Request #669 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

also, fixed some typos and changed from NotImplementedError to ControlMIMONotImplemented error where needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sawyerbfuller
misc bugfixes: fixed prewarp not working in c2d and sample_system, in…
ca8e670 
…correct order of return arguments in margin, typos and changed to ControlMIMONotImplemented error where needed.
@coveralls

coveralls commented Nov 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.08%) to 90.017% when pulling 4c66fb1 on sawyerbfuller:bugfixes1 into e9c224c on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator reviewed Nov 5, 2021
View reviewed changes
Comment thread control/margins.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller added 2 commits November 5, 2021 14:17
@sawyerbfuller
reverted mistaken margin argument rearrangement and clarified definit…
bc5079b 
…ions in docstring of margin
@sawyerbfuller
clarified docstring in stability-margins
cfb6e86
@sawyerbfuller sawyerbfuller changed the title misc bugfixes: fixed prewarp not working in c2d and sample_system, corrected order of return arguments in margin fixed prewarp not working in c2d and sample_system, margin docstring improvements Nov 5, 2021
bnavigator
bnavigator reviewed Nov 6, 2021
View reviewed changes
Comment thread control/dtime.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread control/dtime.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sawyerbfuller
test prewarp in c2d and sample_system
4c66fb1
@bnavigator
bnavigator merged commit 5155dd5 into python-control:master Nov 8, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sawyerbfuller @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.