GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Additional I/O system type conversions by murrayrm · Pull Request #672 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR adds some type conversations for algebraic operations involving I/O systems, motivated by an example I was putting together where I wanted to generate a Nyquist plot for a linearized nonlinear I/O system (type LinearIOSystem) and a simple lead compensator (type TransferFunction). Using P * C generated a type conversation error but C * P was OK as was ct.tf(P) * C. It seemed annoying to have to do the explicit typecasting, so I decided to implement some of the operations that were needed to make P * C work (generates a LinearICSystem, which is a subclass of StateSpace).

The following functionality has been added:

  • Added __sub__, so that you can write G1 - G2 for I/O systems
  • Added conversions for scalars, arrays, state space, and transfer function systems so that they can be combined with I/O systems on either the left or right.
  • Set the Numpy __array_priority__ value so that operations involving ndarrays are handled as I/O system operations and I/O system operations take precedence over LTI operations involving ndarrays.

I also did some PEP8 cleanup on iosys.py while I was at it, and put in unit tests for the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
murrayrm added 3 commits November 21, 2021 14:53
@murrayrm
add iosys conversions (mul, rmul, add, radd, sub, rsub) + PEP8 cleanup
4023edd
@murrayrm
update tests to avoid NumPy matrix deprecation
8912b77
@murrayrm
add a few more unit tests for coverage
be9e7ea
@murrayrm
murrayrm force-pushed the ios-mixedops branch from 7722f9f to be9e7ea Compare November 21, 2021 22:54
@murrayrm

murrayrm commented Nov 21, 2021

Copy link
Copy Markdown
Member Author

Rebased on top of latest master...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coveralls

coveralls commented Nov 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 90.119% when pulling a44d1a4 on murrayrm:ios-mixedops into 56cecc0 on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnavigator
bnavigator reviewed Nov 23, 2021
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

murrayrm added 2 commits November 26, 2021 09:51
@murrayrm
respond to review comments from @bnavigator
93c3f5c
@murrayrm
TRV: fix docstring typo
a44d1a4
@murrayrm
murrayrm merged commit 20088d1 into python-control:master Nov 27, 2021
@murrayrm
murrayrm deleted the ios-mixedops branch November 27, 2021 18:35
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@murrayrm murrayrm mentioned this pull request Dec 30, 2021
Implement missing type conversions for block diagram algebra #513
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.