GeezerVison is showing github.com — Additional I/O system type conversions by murrayrm · Pull Request #672 · python-control/python-control
Conversation
murrayrm
commented
Nov 21, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR adds some type conversations for algebraic operations involving I/O systems, motivated by an example I was putting together where I wanted to generate a Nyquist plot for a linearized nonlinear I/O system (type LinearIOSystem) and a simple lead compensator (type TransferFunction). Using P * C generated a type conversation error but C * P was OK as was ct.tf(P) * C. It seemed annoying to have to do the explicit typecasting, so I decided to implement some of the operations that were needed to make P * C work (generates a LinearICSystem, which is a subclass of StateSpace).
The following functionality has been added:
- Added
__sub__, so that you can write G1 - G2 for I/O systems
- Added conversions for scalars, arrays, state space, and transfer function systems so that they can be combined with I/O systems on either the left or right.
- Set the Numpy
__array_priority__ value so that operations involving ndarrays are handled as I/O system operations and I/O system operations take precedence over LTI operations involving ndarrays.
I also did some PEP8 cleanup on iosys.py while I was at it, and put in unit tests for the code.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Rebased on top of latest master...
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coveralls
commented
Nov 21, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

Coverage increased (+0.04%) to 90.119% when pulling a44d1a4 on murrayrm:ios-mixedops into 56cecc0 on python-control:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|