GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improved lqe calling functionality by murrayrm · Pull Request #673 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Nov 26, 2021

Copy link
Copy Markdown
Member

This PR updates the lqe() function to allow it to be called with a StateSpace system as the first argument rather than the matrices that define the system. This matches the functionality of the lqr command. Docstrings have been updated to reflect the new functionality and to match the notation used for lqr a bit better. Unit tests added to cover the new code.

This PR has some overlap with #670, so depending on which gets merged first it may be necessary to rebase.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits November 24, 2021 22:06
@murrayrm
update lqe() argument processing to match lqr()
1e55a03
@murrayrm
updated docstrings + unit tests
06aa0d8
@coveralls

coveralls commented Nov 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 90.175% when pulling 31729c8 on murrayrm:enh-lqe into 56cecc0 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm mentioned this pull request Nov 26, 2021
DLQR and DLQE #670
Merged
bnavigator
bnavigator reviewed Nov 26, 2021
View reviewed changes
Comment thread control/statefbk.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
remove comment per @sawyerbfuller
31729c8
@bnavigator
bnavigator merged commit 81a4f38 into python-control:master Dec 2, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator left review comments
@sawyerbfuller sawyerbfuller sawyerbfuller left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @bnavigator @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.