GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — vectorize FRD feedback function by bnavigator · Pull Request #680 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

This is a TODO from #314. It overlaps with #679 and one or the other needs a rebase after merge.

# frd_bench.py
from control import FrequencyResponseData, rss
import numpy as np

omega = np.logspace(-1, 4, 40000)

rss1 = rss(6,10,20,True)
rss2 = rss(6,20,10,True)

F1 = rss1(omega)
F2 = rss2(omega)

frd1 = FrequencyResponseData(F1, omega)
frd2 = FrequencyResponseData(F2, omega)

FB = frd1.feedback(frd2)

current master:

In [1]: from frd_bench import frd1,frd2

In [2]: %timeit -n 10 -r 3 frd1.feedback(frd2)
1.96 s ± 10.8 ms per loop (mean ± std. dev. of 3 runs, 10 loops each)

vectorized:

In [1]: from frd_bench import frd1,frd2

In [2]: %timeit -n 10 -r 3 frd1.feedback(frd2)
1.29 s ± 4.48 ms per loop (mean ± std. dev. of 3 runs, 10 loops each)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
vectorize FRD feedback function
323ae3d
@coveralls

coveralls commented Dec 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 92.723% when pulling 37c95b6 on bnavigator:vector-frd-feedback into 4f681ab on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
Merge branch 'master' into vector-frd-feedback
37c95b6
@bnavigator

bnavigator commented Dec 26, 2021

Copy link
Copy Markdown
Contributor Author

It overlaps with #679 and one or the other needs a rebase after merge.

Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
murrayrm
murrayrm approved these changes Dec 26, 2021
View reviewed changes
@murrayrm
murrayrm merged commit 2ce4bbd into python-control:master Dec 26, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator
bnavigator deleted the vector-frd-feedback branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.