GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — extrapolation in ufun throwed errors by miroslavfikar · Pull Request #682 · python-control/python-control

Conversation

@miroslavfikar

@miroslavfikar miroslavfikar commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

I came across situation when interpolation of u in ufun was requested beyond the actual time interval. Attached MWE file throws error, proposed modification resolves the issue. There were two possibilities to resolve the issue: either to take the highest value of time known (interpolation) or to prolonge the last interval to the right (extrapolation). I chose the first one to be consistent with already treated case to the left.

testh2.txt

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@miroslavfikar
extrapolation in ufun throwed errors
306a216
@murrayrm

murrayrm commented Dec 12, 2021

Copy link
Copy Markdown
Member

@miroslavfikar It would be great to add a unit test the triggers the error (prior to your fix).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coveralls

coveralls commented Dec 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.002%) to 92.721% when pulling 9bd61b0 on miroslavfikar:mifi_ufun into 2ce4bbd on python-control:master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
update iosys ufun to extrapolate
5a75ca0
@murrayrm

murrayrm commented Dec 26, 2021

Copy link
Copy Markdown
Member

I updated the fix to use extrapolation, since this is what is supposed to happen. The example now runs without throwing and error. (I couldn't figure out how to create a simple unit test since it seem to depend on the integrator asking to sample outside of the time range.)

@miroslavfikar It would be useful if you can confirm that the new version gives a correct result for your example.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miroslavfikar

miroslavfikar commented Dec 26, 2021

Copy link
Copy Markdown
Contributor Author

@murrayrm Yes, I confirm, I get the correct results with your commit, thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miroslavfikar
Merge branch 'python-control:master' into mifi_ufun
9bd61b0
@murrayrm
murrayrm merged commit 8356044 into python-control:master Dec 26, 2021
@miroslavfikar
miroslavfikar deleted the mifi_ufun branch December 26, 2021 18:39
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miroslavfikar @murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.