GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||
GeezerVison is showing github.com — LQR using SciPy by murrayrm · Pull Request #683 · python-control/python-control Conversation
Member
This PR updates the I implemented this by changing all of the Other changes:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Merged
|
There was an error while loading. Please reload this page.
|
Coverage increased (+0.7%) to 93.433% when pulling 801f282 on murrayrm:lqr_scipy into 4f681ab on python-control:master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few minor comments:
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| elif method == 'slycot': | ||
| return _dare_slycot(A, B, Q, R, S, E, stabilizing) | ||
|
|
||
| else: | ||
| _check_shape("B", B, n, m) | ||
| _check_shape("Q", Q, n, n, square=True, symmetric=True) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Maybe _dare_slycot() and _dare_scipy() should be on the same level?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I agree the asymmetry is annoying. I left it this way to avoid changing code that was working. In care everything is in the main function, so at some point we should clean all of these up to be more uniform (either a single function or use _method uniformly).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.