GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — Round to nearest integer decade for default omega vector by bnavigator · Pull Request #688 · python-control/python-control Conversation
Contributor
Fixes #687. The docstring for the
The old code rounded to the floor and ceiling of the range, which occasionally adds another decade to one or the other end of the frequency range if the feature falls just inside of the outermost decade. The new code rounds to the nearest integer, so it only adds half a decade at minimum.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Coverage increased (+0.09%) to 93.591% when pulling 021372f on bnavigator:omega_default_round into a111b03 on python-control:master. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@bnavigator In thinking through this overnight, I wonder if we might want to revert to the old behavior (floor, ceil) and update the documentation to match (+ update the unit tests to avoid the corner case). I'm worried that only going out a half decade might now show the asymptotic frequency response. I'll work up a couple of examples and post an issue so that we can discuss. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmm, okay. We need to find another way to make |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
python-control 0.9.1 fails intest_nyquist_indent on aarch64
There was an error while loading. Please reload this page.