GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Interpret str-type args to `interconnect` as non-sequence by roryyorke · Pull Request #698 · python-control/python-control

Conversation

@roryyorke

@roryyorke roryyorke commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

If the arguments inputs or outputs (or their aliases input or
output) are of type str, treat as a list containing that string.

Fixes gh-692.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@roryyorke
Interpret str-type args to interconnect as non-sequence
37d3148 
If the arguments `inputs` or `outputs` (or their aliases `input` or
`output`) are of type str, treat as a list containing that string.

Fixes python-controlgh-692.
@coveralls

coveralls commented Jan 29, 2022

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 93.595% when pulling 37d3148 on roryyorke:rory/interconnect-io-str into e8db508 on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Jan 29, 2022
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
murrayrm merged commit e10855e into python-control:master Jan 30, 2022
@roryyorke
roryyorke deleted the rory/interconnect-io-str branch February 5, 2022 04:50
@murrayrm murrayrm added this to the 0.9.2 milestone Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.2

Development

Successfully merging this pull request may close these issues.

Interconnect treats string as list

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@roryyorke @coveralls @bnavigator @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.