GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Slycot source uses setuptools_scm now by bnavigator · Pull Request #751 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

python-control/Slycot#180 broke the CI setup for the tests with a Slycot from latest sources (0.5.1.dev6 at the moment).

Given that the change blocks proper CI runs in PRs like #750, I intend to merge this as soon as the CI passes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
Slycot source uses setuptools_scm
0ff9191
@bnavigator
bnavigator force-pushed the slycot-5.1.dev branch from 027aebd to 0ff9191 Compare July 18, 2022 09:32
@coveralls

coveralls commented Jul 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.09%) to 94.634% when pulling 0ff9191 on bnavigator:slycot-5.1.dev into 2f29a4c on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 6f124ec into python-control:main Jul 18, 2022
@murrayrm

murrayrm commented Jul 18, 2022

Copy link
Copy Markdown
Member

@bnavigator This PR looks fine, but I note that it now builds against that latest Slycot in available via pip, versus the previous behavior which checked against the latest version on github.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

Are you sure?
Successfully installed slycot-0.5.1.dev6+g5a6858f

This is the latest version on github.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Jul 18, 2022

Copy link
Copy Markdown
Member

Ah, I see now. I was confused about how the repository was being check out. I agree the behavior is unchanged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
@bnavigator
bnavigator deleted the slycot-5.1.dev branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.