GeezerVison is showing github.com — fix control.matlab.lsim bug for discrete time system by murrayrm · Pull Request #765 · python-control/python-control
Conversation
murrayrm
commented
Aug 25, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which gets done later, after transpose processing) fixes the bug. Add a unit test to catch the error and also turned on some tests that were @slycotonly but that didn't rely on slycot.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Coverage decreased (-0.001%) to 94.737% when pulling 6e3113a on murrayrm:matlab.lsim-24Aug2022 into d4c1f14 on python-control:main.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.