GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update benchmarks to help with optimal control tuning by murrayrm · Pull Request #800 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Nov 26, 2022

Copy link
Copy Markdown
Member

This PR updates the benchmarks to allow for more useful characterization and tuning of the optimal module. The main change is to switch from using the kinematic car (vehicle) example as the basis for benchmarking to using a simpler linear system. The kinematic car was problematic because it is a marginally stable system and so the shooting method using for the optimal control computations was not numerically stable, causing lots of failures.

Almost all of the changes here are in the benchmarks/ directory, with a few small changes in the main code to fix some small issues identified along the way.

Once this PR and #799 are merged, I'll add some benchmarks comparing the shooting method to collocation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 5 commits November 19, 2022 08:04
@murrayrm
move optimal_bench.py to steering_bench.py + small fixes
e14d7b3
@murrayrm
improved flat system benchmarking (+ docstring, unit test updates)
08f6464
@murrayrm
new optimal benchmarks (replace steering with rss)
efca9ca
@murrayrm
add error for using solve_ivp for discrete time + formatting tweaks
2860d89
@murrayrm
allow print_summary to be set in solve_ocp
54de2a3
@coveralls

coveralls commented Nov 26, 2022

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 94.842% when pulling 54de2a3 on murrayrm:benchmarks-24Aug2022 into 832527d on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 4d89991 into python-control:main Nov 26, 2022
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.