GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — Update docstring for impulse for discrete sys by sawyerbfuller · Pull Request #812 · python-control/python-control ConversationUpdate impulse_response doc string to indicate that the impulse size is unit area for discrete systems.
|
There was an error while loading. Please reload this page.
|
We definitely need to update the documentation, but I wonder whether we shouldn't also consider what the right definition of the impulse response is for a discrete time system with non-unit sampling time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I made this change a little while back to match what matlab does, which is a unit-area impulse for discrete-time systems: https://www.mathworks.com/help/control/ref/lti.impulse.html. This arrangement is probably what you want if you are viewing a discrete-time system as a discretized model of a continuous-time system. Probably unit area is favored by engineering, unit magnitude by math. Probably a subjective choice. Anybody here have further insight into such a choice? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
As the sampling You can test it yourself by generating a [1, 0, 0, 0, ...] array and supply to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ilayn's comment makes it clear why scaling by the sampling time is the right approach (and I was mistaken about what MATLAB does). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Scaling difference in impulse response size compared to scipy.signal
There was an error while loading. Please reload this page.