GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add zpk() function by murrayrm · Pull Request #816 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR adds the function zpk, which creates a transfer function (as a NamedIOSystem) from a zero, pole, gain representation. This responds to issue #749.

Also added in code to make sure that signal names are copied correctly in various conversions, removing some comments entered in PR #804. In _convert_to_transfer_function this involved removing renaming from the low level function, as documented in the comment string.

Notes:

  • Unlike in MATLAB and SciPy, which have zpk classes, here we just create a transfer function from the zpk data. That seems like the most common use case.

  • In the matlab module there are also functions zpk2ss and zpk2tf that implement lower level behavior (eg, zpk2ss returns A, B, C, D). This is similar to MATLAB. if you want to get a StateSpace system from a zpk representation, use sys = ct.ss(ct.zpk(zeros, poles, gain)).

  • Unit tests and updated documentation are also included.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@coveralls

coveralls commented Dec 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 94.817% when pulling 7ee0c0e on murrayrm:zpk-13Dec2022 into b4cd96b on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm murrayrm linked an issue Dec 16, 2022 that may be closed by this pull request
Include a zpk2tf function #749
Closed
@murrayrm
add zpk() function
91466d1
@murrayrm
murrayrm force-pushed the zpk-13Dec2022 branch 2 times, most recently from 7983829 to a123f15 Compare December 17, 2022 15:29
@murrayrm
fix up copying of signal names
7ee0c0e
@murrayrm
murrayrm force-pushed the zpk-13Dec2022 branch from a123f15 to 7ee0c0e Compare December 17, 2022 15:34
bnavigator
bnavigator approved these changes Dec 17, 2022
View reviewed changes
@murrayrm
murrayrm merged commit 821bfa9 into python-control:main Dec 17, 2022
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

Include a zpk2tf function

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.