GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Relax comparison of floats in tests by bnavigator · Pull Request #818 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

While trying to fix python-control/Slycot#187 in python-control/Slycot#188, I ran into precision related errors of the control test suite. Seems like the new NumPy moves around some libraries affecting the floats.

There are more errors related to the frequency vector calculation of FRDs, which need to be investigated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bnavigator added 2 commits December 18, 2022 21:32
@bnavigator
compare floats as almost equal
089ca21
@bnavigator
increase nulps
e13f57f
@bnavigator bnavigator changed the title Easy comparison of floats in tests Relax comparison of floats in tests Dec 18, 2022
@bnavigator bnavigator mentioned this pull request Dec 18, 2022
pin numpy to <1.24 during build due to gh-187 python-control/Slycot#188
Merged
@coveralls

coveralls commented Dec 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 94.803% when pulling 5352222 on bnavigator:flatsys-float-tests into 2f343be on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Dec 19, 2022

Copy link
Copy Markdown
Member

Odd that we are still seeing the FRD error and that this only happens in the slycot from source version.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Dec 20, 2022

Copy link
Copy Markdown
Member

I'm seeing some problems in my own copy of this branch. It looks like using nulps is the source of the problems, but it doesn't happen on all builds. ???
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
fix FRD test errors (use exact freq points)
5352222
@murrayrm

murrayrm commented Dec 21, 2022

Copy link
Copy Markdown
Member

It looks like the problem in the FRD tests had to do with using np.linspace to generate the list of frequencies and then specifying a subset of frequencies for testing "manually". Picking the frequencies out from the original list seems to have fixed the problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 21, 2022

Copy link
Copy Markdown
Contributor Author

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 56f227f into python-control:main Dec 21, 2022
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
@bnavigator
bnavigator deleted the flatsys-float-tests branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

Numpy 1.24 breaks compiling Slycot

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.