GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update find_eqpts to handle discrete time systems by murrayrm · Pull Request #824 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 24, 2022

Copy link
Copy Markdown
Member

This PR addresses issue #823 and adds the functionality required for iosys.find_eqpts to compute equilibrium points for discrete time systems. Includes unit tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
add code + tests for discrete time find_eqpt
5d0b3d0
@murrayrm murrayrm linked an issue Dec 24, 2022 that may be closed by this pull request
find_eqpt for discrete-time system #822
Closed
@coveralls

coveralls commented Dec 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 94.846% (+0.04%) from 94.803% when pulling 0bde571 on murrayrm:findeqpt_dtime-24Dec2022 into f15fc0f on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
@Maksymilian-Plywaczyk

Maksymilian-Plywaczyk commented Dec 28, 2022

Copy link
Copy Markdown

Hello,

When can you expect the pull request to be completed? For me is urgent.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Dec 28, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@Maksymilian-Plywaczyk you can use pip install git+https://github.com/murrayrm/python-control@findeqpt_dtime-24Dec2022 right now. (Don't be confused with the resulting version, @murrayrm's github fork is missing a few tags but it is not critical)

Update: You can use pip install git+https://github.com/python-control/python-control now.

If you are using conda, do this from your anaconda prompt in the correct environment and do conda remove control before.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Dec 28, 2022
View reviewed changes
bnavigator
bnavigator reviewed Dec 28, 2022
View reviewed changes
Comment thread control/iosys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
add documentation for continuous vs discrete find_eqpt computation
0bde571
@murrayrm
murrayrm merged commit 313ca74 into python-control:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

find_eqpt for discrete-time system

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@murrayrm @coveralls @Maksymilian-Plywaczyk @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.