GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Small fixes and tweaks by murrayrm · Pull Request #826 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Dec 28, 2022

Copy link
Copy Markdown
Member

This PR has some small fixes and tweaks in preparation for release of control-0.9.3. Nothing major:

  • Fixed a few small typos/grammar errors in docstrings and comments
  • Fixed improper call to an exception in timeresp.py (missing raise statement)
  • Added quotes + build type for JOBNAME in os-blas-test-matrix.yml
  • Added more careful checking of xfail for a case in optimal_test.py

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 5 commits December 24, 2022 18:37
@murrayrm
fix improper exception in timeresp.py
57ec9ff
@murrayrm
fix typo in describing_function docstring
9837a97
@murrayrm
handle lack of $JOBNAME in flatsys properly
3955064
@murrayrm
add quotes to JOBNAME expansion + build type
363ea2b
@murrayrm
more careful checking of xfails in optimal_test.py
5757f2f
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 28, 2022
@coveralls

coveralls commented Dec 28, 2022

Copy link
Copy Markdown

Coverage Status

Coverage: 94.803%. Remained the same when pulling 5757f2f on murrayrm:smallfixes-04Aug2022 into f15fc0f on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Dec 28, 2022
View reviewed changes
@murrayrm
murrayrm merged commit 49b0077 into python-control:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.