GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems by henklaak · Pull Request #863 · python-control/python-control

Conversation

@henklaak

@henklaak henklaak commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Function argument clobbered by local assignment. Use local variable instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
henklaak added 4 commits February 17, 2023 13:58
@henklaak
Solve #862: bode_plot phase wrapping incorrect for multiple systems
b6769f6
@henklaak
Fix wrap
2afd397
@henklaak
PEP8 requires lowercase variable name
f990f40
@henklaak
Don't plot in tests...
f2878d5
@henklaak

henklaak commented Feb 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

matplotlib 3.6.3 => 3.7.* seems to break our tests. Will investigate further.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@henklaak
Fix regression with matplotlib 3.7.0
4c4b3fc
@henklaak

henklaak commented Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

Solves #862 and #864. If you prefer, I can make separate PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@henklaak henklaak changed the title Solve #862: bode_plot phase wrapping incorrect for multiple systems Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems Feb 17, 2023
@coveralls

coveralls commented Feb 17, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: 94.872%. Remained the same when pulling 4c4b3fc on henklaak:main into c4d1764 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Feb 18, 2023

Copy link
Copy Markdown
Member

Thanks for the fixes!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 346bc40 into python-control:main Feb 18, 2023
This was referenced Feb 18, 2023
Matplotlib 3.7 breaks nyquist_plot() #864
Closed
bode_plot phase wrapping incorrect for multiple systems. #862
Closed
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henklaak @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.