GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix root_locus() handling of ax parameter by henklaak · Pull Request #871 · python-control/python-control

Conversation

@henklaak

@henklaak henklaak commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Fixes #870

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henklaak
Fix root_locus() handling of ax parameter
d13f1ed
@coveralls

coveralls commented Feb 22, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: 94.883% (+0.01%) from 94.872% when pulling d13f1ed on henklaak:fix_root_locus_ax into 346bc40 on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller

sawyerbfuller commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

This seems like a more straightforward and correct way of implementing sgrid - can you confirm sisotool still works as you might expect on that transfer function, and that the gridlines turn off when rlocus_grid=False?

Also, we currently have an excess of sgrid functions. There is another : ) It is to be found in grid.py and it is called sgrid. I haven't compared the two but that one may be more modern/faster? (though it also needs to be upgraded to accept an ax keyword). If so, maybe the root_locus function should switch to using that one and delete the one in rlocus.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@henklaak

henklaak commented Feb 22, 2023

Copy link
Copy Markdown
Contributor Author

@sawyerbfuller
Sisotool still works (as far as I know how to use it) and the grid is 'switchable'.

The harmonization of different grid implementations is outside the scope of this Issue/PR. I can take a stab at it later.

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller

sawyerbfuller commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

Looks good to me

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sawyerbfuller
sawyerbfuller merged commit 8972e82 into python-control:main Feb 23, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

root_locus() does not properly handle ax parameter

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@henklaak @coveralls @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.