GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Small fixes for 0.9.4 release by murrayrm · Pull Request #880 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Mar 27, 2023

Copy link
Copy Markdown
Member

This PR implements a number of small fixes for issues tagged for resolution in release 0.9.4:

  • Updated installation documentation to recommend conda installation first, then pip (resolves Change installation instructions to recommend Conda, warn about compiling Slycot #850)
  • Added more documentation about Nyquist plot scaling (resolves Incorrect nyquist plot #830)
  • Deprecated issys() (resolves ctrlutil.issys() is confusing (tests for LTI) #876)
  • Changed short package name for control.optimal from opt to obc consistently throughout documentation.
  • Fixed sphinx processing of version to allow proper links to source code (resolves Readthedocs points to wrong version of source code for .postN release #837).
  • Added numpy 1.24.2 to list of exceptions for flatness test on linux using Generic BLAS (resolves Numpy 1.24.2 breaks OS/BLAS test matrix #866).
  • Additional updates to docstrings and rst files as I went through the above items.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@coveralls

coveralls commented Mar 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 94.535% (+0.001%) from 94.533% when pulling 1d7480a on murrayrm:smallfixes-26Mar2023 into 0422c82 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
murrayrm added 7 commits March 31, 2023 13:16
@murrayrm
use obc as standard prefix for control.optimal
981104b
@murrayrm
update installation instructions per issue python-control#850
6a18702
@murrayrm
deprecate ctrlutil.issys()
1d670a7
@murrayrm
add documentation on scaled portions of Nyquist plot
423744a
@murrayrm
fix sphinx version processing to point to released source code
1aa6a7e
@murrayrm
add known failure for OS/BLAS matrix: numpy 1.24.2
7350e79
@murrayrm
reset_defaults() at start of each doctest
1d7480a
@murrayrm
murrayrm force-pushed the smallfixes-26Mar2023 branch from ee173f2 to 1d7480a Compare March 31, 2023 20:17
sawyerbfuller
sawyerbfuller approved these changes Mar 31, 2023
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
murrayrm merged commit 999189c into python-control:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

ctrlutil.issys() is confusing (tests for LTI) Numpy 1.24.2 breaks OS/BLAS test matrix Change installation instructions to recommend Conda, warn about compiling Slycot Readthedocs points to wrong version of source code for .postN release Incorrect nyquist plot

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.