GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — new examples for Simulink-like interconnection of digital and nonlinear systems by sawyerbfuller · Pull Request #882 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Apr 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The goal of this PR is to provide examples of how to use interconnect to create sophisticated interconnections of systems of different types in a manner that is reminiscent of Simulink. In particular, simulating_sampled_data_systems.ipynbsimulating_discrete_nonlinear.ipynb provides a few helper functions to accurately simulate interconnections of discrete-time controllers, a nonlinear plant, and time delays.

Since Python does not have a great numerical integration system for delay differential equations, the approach that is used is to discretize all of the components with a short time interval, including the discrete-time controller.

A future PR will incorporate some of these helper functions into the library, particularly sampled_data_controller().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sawyerbfuller
add new examples of interconnect and simulating sampled data systems.
07c9e63
@coveralls

coveralls commented Apr 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 94.535%. Remained the same when pulling c703650 on sawyerbfuller:interconnect-examples into 999189c on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
murrayrm
murrayrm reviewed Apr 8, 2023
View reviewed changes
Comment thread doc/examples.rst

cruise
describing_functions
interconnect_tutorial

@murrayrm murrayrm Apr 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the introductory text at the top of this section since the Jupyter notebooks in this section are no longer using running examples in FBS2e (true before this change, but I noticed it now). How about something like:

These notebooks demonstrate the use of modeling, anaylsis, and design tools
using examples from textbooks (FBS2e, OBC), courses, and other sources.

(links would have to be done differently, but using GitHub markup here to show where the links go).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sawyerbfuller sawyerbfuller Apr 9, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. INcorporated the suggested rewording.

Also improved the name on one of the examples and switched to lists for specifying set of interconnected systems according to upcoming changes in interconnect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sawyerbfuller added 2 commits April 9, 2023 16:28
@sawyerbfuller
reword examples according to @murrayrm suggestion, change example to …
7733044 
…be compatible with new interconnect
@sawyerbfuller
fix link in examples.rst
f55ec01
@murrayrm

murrayrm commented Apr 10, 2023

Copy link
Copy Markdown
Member

The new notebook name is really long (56 characters!). Perhaps worth a bit of discussion about file naming conditions in this folder. I have been trying to use shorter names (eg, 'mhe-pvtol' and 'stochresp'), but there are a few longer ones (e.g. 'check-controllability-and-observability.py').

Do we care?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller added 2 commits April 10, 2023 21:18
@sawyerbfuller
shorten long filename
81197fd
@sawyerbfuller
shorten long filename
c703650
@sawyerbfuller

sawyerbfuller commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

@murrayrm I think that filename was a bit long. Took a stab at shortening it.

In any case, the title of the notebook is what appears in the readthedocs page, not its filename:

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 1e1c8eb into python-control:main Apr 11, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murrayrm murrayrm murrayrm left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawyerbfuller @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.