GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix damp command natural frequency printout for discrete poles on real axis by sawyerbfuller · Pull Request #894 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented May 22, 2023

Copy link
Copy Markdown
Contributor

The damp command was assuming a cont-time system when printing out pole locations (but the return value was correct). Fixed, along with making a few docstring improvements.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sawyerbfuller added 3 commits May 22, 2023 14:37
@sawyerbfuller
fix damp command natural frequency printout for discrete poles on rea…
47cbe72 
…l axis; docstring fixes
@sawyerbfuller
docstring make explicit that doprint is optional
cec6b5c
@sawyerbfuller
output more readable
6cfd466
@sawyerbfuller

sawyerbfuller commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Example:

sysd = ct.zpk([], [-1.1, 1+1j, 1-1j], 1, True)
ct.damp(sysd)

Old (pole at -1.1 has the wrong frequency, table is hard to read):

_____Eigenvalue______ Damping___ Frequency_
         1        +1j    -0.4037     0.8585
         1        -1j    -0.4037     0.8585
      -1.1                     1        1.1

New:

    Eigenvalue (pole)       Damping     Frequency
         1        +1j       -0.4037        0.8585
         1        -1j       -0.4037        0.8585
                 -1.1             1         3.143
joaoantoniocardoso reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented May 28, 2023

Copy link
Copy Markdown
Member

LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 1b84d80 into python-control:main May 28, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.