GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — warn if prewarp-frequency is not used by sawyerbfuller · Pull Request #900 · python-control/python-control

Conversation

@sawyerbfuller

@sawyerbfuller sawyerbfuller commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

This PR makes sure the prewarp-frequency kwarg is used in sys.sample.

  • now warns if a descretization type doesn't support it
  • now c2d is an identical copy of sample_system instead of being a somewhat-compatible version of it
  • more/better unit tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sawyerbfuller
warn if prewarp-frequency is not used and tests, make c2d an identica…
29c9432 
…l copy to sample_system instead of a separate function
@coveralls

coveralls commented Jun 2, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 94.623% (+0.003%) from 94.62% when pulling 29c9432 on sawyerbfuller:tustin-prewarp into fe4589b on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit 0c46562 into python-control:main Jun 3, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawyerbfuller @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.