GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Doc remove linear io system by KybernetikJo · Pull Request #922 · python-control/python-control

Conversation

@KybernetikJo

@KybernetikJo KybernetikJo commented Jul 11, 2023

Copy link
Copy Markdown
Contributor
  • Replace LinearIOSystem with StateSpace and LinearICSystem in docstrings
  • Reruns jupyter notebooks

I have a question:
When a PR is merged, the sphinx help is built, but jupyter notebooks are not executed again? Is that right?

I am not sure if the second commit (Rerun jupyter ....) is really necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
KybernetikJo added 2 commits July 11, 2023 23:37
@KybernetikJo
Replace LinearIOSystem in doctrings
6133fd0
@KybernetikJo
Rerun jupyter notebooks in order to get rid of LinearIOSystem outputs,
0810502
@coveralls

coveralls commented Jul 11, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 94.849%. remained the same when pulling 0810502 on KybernetikJo:doc_remove_LinearIOSystem into a8658e4 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Jul 12, 2023

Copy link
Copy Markdown
Member

@KybernetikJo I don't believe that the Jupyter notebooks are regenerated when generating Sphinx output on readthedocs. So what you did is required if you want readthedocs to show the output correctly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm
murrayrm merged commit cf27186 into python-control:main Jul 12, 2023
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@KybernetikJo @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.