GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add unit test illustrating issue #935 + add method keyword for tf2ss by murrayrm · Pull Request #937 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Oct 22, 2023

Copy link
Copy Markdown
Member

This PR puts in some unit tests associated with issue #935, which looks like it is a problem in slycot where the tf2ss functionality (in td04ad) doesn't work properly. As a partial workaround, a method keyword is added to tf2ss (and ss) that allows method='scipy' to be used for SISO systems. Docstrings updated for the new keyword and a note on the slycot issue.

A bug report has been created in the slycot repository (#222 and the unit tests will fail when the bug is fixed (so we can go back and update the unit tests and documentation).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits October 22, 2023 07:10
@murrayrm
add unit test illustrating issue python-control#935 + add keyword for…
fe8888f 
… tf2ss
@murrayrm
add some documentation and notes
2580d18
@murrayrm murrayrm linked an issue Oct 22, 2023 that may be closed by this pull request
tf2ss() returns unstable system #935
Closed
@murrayrm murrayrm removed a link to an issue Oct 22, 2023
tf2ss() returns unstable system #935
Closed
@coveralls

coveralls commented Oct 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 95.003%. first build
when pulling 31793e6 on murrayrm:tf2ss_unstable_bug-21Oct2023
into a44def1 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Oct 26, 2023
View reviewed changes
Comment thread control/statesp.py
@@ -2250,6 +2274,8 @@ def _convert_to_statespace(sys, use_prefix_suffix=False):
A, B, C, D = \

@sawyerbfuller sawyerbfuller Oct 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change for the two lines above:

if not issiso(sys):
    raise ControlMIMONotImplemented("MIMO system conversion not supported without Slycot")

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread control/statesp.py
sp.signal.tf2ss(squeeze(sys.num), squeeze(sys.den))
newsys = StateSpace(A, B, C, D, sys.dt)
else:
raise ValueError(f"unknown {method=}")

@sawyerbfuller sawyerbfuller Oct 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First instantiation of self-documenting F-strings in python-control? : )

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
updated MIMO not implemented w/ unit test, per @sawyerbfuller
31793e6
@murrayrm
murrayrm merged commit 2ddc9ea into python-control:main Nov 8, 2023
@murrayrm
murrayrm deleted the tf2ss_unstable_bug-21Oct2023 branch November 8, 2023 06:39
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @sawyerbfuller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.