GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove np.int by AbhiramShenoiKodiak · Pull Request #978 · python-control/python-control

Conversation

@AbhiramShenoiKodiak

@AbhiramShenoiKodiak AbhiramShenoiKodiak commented Mar 20, 2024

Copy link
Copy Markdown

In numpy versions >1.24 the usage of np.int has been deprecated. This is the only file that uses this.

This PR makes a change to allow python-control to be compatible with numpy > 1.24.

https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AbhiramShenoiKodiak
remove np.int
cd8b70a
@bnavigator

bnavigator commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Thanks, but this is unused old code. This should be "fixed" when actually merged into python-control or be removed.

An thoughts @robertobucher, @murrayrm?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator

bnavigator commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Also, if we fix it, Plain int instead of np.int64 should be used.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AbhiramShenoiKodiak
Update yottalab.py
429a5a0
@coveralls

coveralls commented Mar 20, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.422%. remained the same
when pulling 429a5a0 on AbhiramShenoiKodiak:patch-1
into 7a70be1 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm

murrayrm commented Mar 30, 2024

Copy link
Copy Markdown
Member

I think we can probably remove the external/ directory. It was there from a time when we were missing some code and I thought people might want to see other implementations. We don't actively use it and it is probably mostly out of date.

I'll post a short PR to remove it and close out this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm closed this Mar 30, 2024
@murrayrm murrayrm mentioned this pull request Mar 30, 2024
Remove external/ directory #983
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AbhiramShenoiKodiak @bnavigator @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.