GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix unit tests that generate multiple warnings by murrayrm · Pull Request #986 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Mar 31, 2024

Copy link
Copy Markdown
Member

In preparing for the v0.10.0 release, I found a few more warnings that were not getting trapped properly. The issue was that you get multiple warnings from a single call, you need to test them separately. This wasn't showing up in local testing, but showed up under the GitHub action runs. So figured it was best to clean them up.

I also ran isort on files that I updated to get some consistency in import statements at the top of files (I've been doing that as I make changes).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@murrayrm
fix unit tests that generate multiple warnings
0cafd68
@coveralls

coveralls commented Mar 31, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.482%. remained the same
when pulling 0cafd68 on murrayrm:fix_warnings-31Mar2024
into c8d9c8f on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm
murrayrm merged commit 1b2abe3 into python-control:main Mar 31, 2024
@murrayrm
murrayrm deleted the fix_warnings-31Mar2024 branch March 31, 2024 16:48
@murrayrm murrayrm added this to the 0.10.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@murrayrm @coveralls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.