GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix typo in ICSystem updfcn, outfcn: update_params -> _update_params by murrayrm · Pull Request #990 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Apr 8, 2024

Copy link
Copy Markdown
Member

This PR fixes a bug in the InterconnectedSystem class, where the updfcn and outfcn methods call update_params instead of _update_params. This bug didn't who up because there were no direct calls to updfcn and outfcn for an IC system. However, these show up in the new phaseplot module code, so it can generate a error.

Simple fix; just adding an underscore in two places (and a unit test to uncover the bug).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm
fix typo in ICSystem updfcn, outfcn: update_params -> _update_params
6b00fd4
@coveralls

coveralls commented Apr 8, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.504% (+0.02%) from 94.482%
when pulling 6b00fd4 on murrayrm:fix_ic_update_params-07Apr2024
into 49f03e7 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnavigator
bnavigator merged commit 1bb0a46 into python-control:main Apr 8, 2024
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.