GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Small updates from Caltech CDS 110 by murrayrm · Pull Request #995 · python-control/python-control

Conversation

@murrayrm

@murrayrm murrayrm commented Apr 20, 2024

Copy link
Copy Markdown
Member

This (draft) PR contains some small fixes that I am making as I teach CDS 110 at Caltech and notice things that can be improved in v0.10.0. Depending on timing and importance, we can decide to include some of all of these into the next patch release (0.10.1).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
murrayrm added 2 commits April 16, 2024 22:30
@murrayrm
set response I/O labels from system for frequency response
03c6bf3
@murrayrm
add better check for find_eqpt with mixed specifications
4905855
@coveralls

coveralls commented Apr 20, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 94.504%. remained the same
when pulling 4905855 on murrayrm:cds110_fixes-16Apr2024
into 1bb0a46 on python-control:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator
bnavigator approved these changes Apr 21, 2024
View reviewed changes

@bnavigator bnavigator left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commits look good to me. Why don't you PR the small fixes one by one and we can include them in to the next release as they come?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@murrayrm

murrayrm commented May 11, 2024

Copy link
Copy Markdown
Member Author

Pulling this PR in favor of smaller ones focused on specific issues, as suggested by @bnavigator.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm closed this May 11, 2024
@murrayrm murrayrm mentioned this pull request May 11, 2024
set response I/O labels from system for frequency response #1000
Merged
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@murrayrm @coveralls @bnavigator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.