GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix nyquist plotting from FrequencyResponseData by wueestry · Pull Request #996 · python-control/python-control

Conversation

@wueestry

@wueestry wueestry commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

This PR resolves the issue #992, by adding a check for FrequencyResponseData during plotting of a nyquist plot and setting omega if not yet set correctly

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
wueestry added 2 commits April 23, 2024 13:27
@wueestry
Fix setting freq range for frd with nyquist
c02c254
@wueestry
Expand nyquist test
0351562
@coveralls

coveralls commented Apr 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

coverage: 94.497% (-0.007%) from 94.504%
when pulling 7fa5960 on wueestry:nyquist_frd
into e1d21d2 on python-control:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@murrayrm

murrayrm commented May 11, 2024

Copy link
Copy Markdown
Member

This is a good fix, but I think we could add a bit better support if there are multiple FRD systems with different frequencies and not explicit frequency list given. For example, try this:

import control as ct
sys = ct.rss(4, 1, 1)
sys1 = ct.frequency_response(sys, np.logspace(-1, 1, 10))
sys2 = ct.frequency_response(sys, np.logspace(-2, 2, 10))
ct.bode_plot([sys1, sys2])                     # works OK
ct.nyquist_plot(sys1, np.logspace(-1, 1, 10))  # works OK
ct.nyquist_plot(sys2, np.logspace(-1, 1, 10))  # generates error (as it should)
ct.nyquist_plot([sys1, sys2])                  # generates error (does it need to?)

It seems to me that the last case should work OK and just plot each system independently, without needing a common frequency range (as it does for Bode plots).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@wueestry
Merge branch 'python-control:main' into nyquist_frd
7fa5960
@murrayrm
murrayrm merged commit dbc998d into python-control:main Jun 8, 2024
This was referenced Jun 13, 2024
Plotting nyquist plot from FrequencyResponseData fails #992
Closed
Frequency plot improvements #1011
Merged
@murrayrm murrayrm added this to the 0.10.1 milestone Jun 30, 2024
@murrayrm murrayrm mentioned this pull request Jun 30, 2024
Version 0.10.1 release plans #1020
Closed
11 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@wueestry @coveralls @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.