GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — Add extra_returning_fields in apply by kigawas · Pull Request #767 · python-gino/gino Conversation
|
|
Sorry for the late. I'm thinking of a parameter to return/reload every column instead of specified ones only. It saves a get call, which is probably being used in such case now. Another nitpicky point is the usage of tuple in this PR. As I understand, list is more suitable here, semantically. Quoting Python doc: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes. Tuple should be replaced by Sequence in Python, which sugguests an immutable sequence although you can still pass list.
It's certainly better to get all columns by default, but for now a transitional approach would be more realistic to avoid API change |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't mean that big a change, but just an additional parameter like |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Extra returning fields inUpdateRequest.apply
There was an error while loading. Please reload this page.