GeezerVison is showing github.com — chore: require kwargs for `utils.copy_dict()` · python-gitlab/python-gitlab@7cf35b2
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: gitlab/client.py +3-3Lines changed: 3 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -647,7 +647,7 @@ def http_request( | 647 | 647 | url = self._build_url(path) | 648 | 648 |
| 649 | 649 | params: Dict[str, Any] = {} | 650 | | - utils.copy_dict(params, query_data) | | 650 | + utils.copy_dict(src=query_data, dest=params) | 651 | 651 |
| 652 | 652 | # Deal with kwargs: by default a user uses kwargs to send data to the | 653 | 653 | # gitlab server, but this generates problems (python keyword conflicts | @@ -656,12 +656,12 @@ def http_request( | 656 | 656 | # value as arguments for the gitlab server, and ignore the other | 657 | 657 | # arguments, except pagination ones (per_page and page) | 658 | 658 | if "query_parameters" in kwargs: | 659 | | - utils.copy_dict(params, kwargs["query_parameters"]) | | 659 | + utils.copy_dict(src=kwargs["query_parameters"], dest=params) | 660 | 660 | for arg in ("per_page", "page"): | 661 | 661 | if arg in kwargs: | 662 | 662 | params[arg] = kwargs[arg] | 663 | 663 | else: | 664 | | - utils.copy_dict(params, kwargs) | | 664 | + utils.copy_dict(src=kwargs, dest=params) | 665 | 665 |
| 666 | 666 | opts = self._get_session_opts() | 667 | 667 |
| |
Collapse file Copy file name to clipboardExpand all lines: gitlab/utils.py +5-1Lines changed: 5 additions & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -44,7 +44,11 @@ def response_content( | 44 | 44 | return None | 45 | 45 |
| 46 | 46 |
| 47 | | -def copy_dict(dest: Dict[str, Any], src: Dict[str, Any]) -> None: | | 47 | +def copy_dict( | | 48 | + *, | | 49 | + src: Dict[str, Any], | | 50 | + dest: Dict[str, Any], | | 51 | +) -> None: | 48 | 52 | for k, v in src.items(): | 49 | 53 | if isinstance(v, dict): | 50 | 54 | # Transform dict values to new attributes. For example: | |
|