GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(objects): Added approval rule name to data by charlesfayal · Pull Request #1011 · python-gitlab/python-gitlab

Conversation

charlesfayal commented Feb 12, 2020

Copy link

Copy Markdown

The new gitlab api needs a name for the approval rules, added a default one to maintain the python-gitlab api.

The prior pull request wasn't ready for merge, needed this fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

max-wittig commented Feb 12, 2020

Copy link

Copy Markdown

Member

Totally missed that. Could you please format your code with black and start the commit message in present tense and small letters? Thanks 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

max-wittig assigned charlesfayal

Feb 12, 2020


          fix(objects): add default name data and use http post

70c0cfb

Updating approvers new api needs a POST call. Also It needs a name of the new rule, defaulting this to 'name'.

charlesfayal commented Feb 15, 2020

Copy link

Copy Markdown

Author

@max-wittig All fixed!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

max-wittig commented Feb 24, 2020

Copy link

Copy Markdown

Member

@charlesfayal Sorry for the delay, but I think there is a small copy paste error

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

max-wittig reviewed

Feb 24, 2020

View reviewed changes

Comment thread

gitlab/v4/objects.py

		data = {
		"approvals_required": approvals_required,
		"name": "name",
		"self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required,

max-wittig Feb 24, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

max-wittig mentioned this pull request

Mar 8, 2020

Fix/set approvers #1039

Merged

max-wittig merged commit 70c0cfb into python-gitlab:master

Mar 8, 2020

Reviewers

max-wittig

max-wittig left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

charlesfayal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.