GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix/keyset pagination revert by max-wittig · Pull Request #1115 · python-gitlab/python-gitlab

Conversation

@max-wittig

@max-wittig max-wittig commented Jun 9, 2020

Copy link
Copy Markdown
Member

/cc @nejch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@max-wittig max-wittig assigned bufferoverflow Jun 9, 2020
@max-wittig
max-wittig force-pushed the fix/keyset-pagination-revert branch from 70db3c6 to b20c307 Compare June 9, 2020 11:06
max-wittig added 2 commits June 9, 2020 13:23
@max-wittig
fix: disable default keyset pagination
e71fe16 
Instead we set pagination to offset on the other paths
@max-wittig
chore: bump version to 2.3.1
870e7ea
@max-wittig
max-wittig force-pushed the fix/keyset-pagination-revert branch from b20c307 to 870e7ea Compare June 9, 2020 11:23
@codecov-commenter

codecov-commenter commented Jun 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1115   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files          10       10           
  Lines        2759     2759           
=======================================
  Hits         2125     2125           
  Misses        634      634

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7dbc8...870e7ea. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bufferoverflow
bufferoverflow approved these changes Jun 9, 2020
View reviewed changes
@bufferoverflow
bufferoverflow merged commit 3f585ad into master Jun 9, 2020
@bufferoverflow
bufferoverflow deleted the fix/keyset-pagination-revert branch June 9, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferoverflow bufferoverflow bufferoverflow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bufferoverflow bufferoverflow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@max-wittig @codecov-commenter @bufferoverflow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.