GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(files): do not url-encode filepaths twice by nejch · Pull Request #1418 · python-gitlab/python-gitlab

Conversation

@nejch

@nejch nejch commented Apr 26, 2021

Copy link
Copy Markdown
Member

Closes #1416.

This is a quick fix for 2.7.0 but we should clean up with #1356 eventually :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nejch
fix(files): do not url-encode file paths twice
8e25cec
@nejch nejch assigned max-wittig Apr 26, 2021
@max-wittig

max-wittig commented Apr 26, 2021

Copy link
Copy Markdown
Member

@nejch Thanks for the fix! I will push out a release right after the pipeline passes 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@max-wittig
max-wittig merged commit 37af229 into master Apr 26, 2021
@max-wittig
max-wittig deleted the fix/urlencode-file-paths branch April 26, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@max-wittig max-wittig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2.7.0 breaks when trying to get pathed files

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nejch @max-wittig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.