GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow masks to be combined with `|` and`&` by eriknw · Pull Request #267 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Jul 4, 2022

Copy link
Copy Markdown
Member

Closes #234

These recipes are much faster than the equivalent recipes in the docstrings, but they still aren't hyper-optimized (they're only semi-optimized). As with .new, this is structured so that any recipe can be updated if need arises.

Currently, all recipes return structural masks that may be complemented. It's not required for them to be structural--perhaps it would be better if some were value masks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Allow masks to be combined with | and&
995c022 
Closes python-graphblas#234
@eriknw
eriknw requested a review from jim22k July 4, 2022 19:17
@eriknw
flake8
1a94f52
@coveralls

coveralls commented Jul 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.005%) to 99.341% when pulling 7cd2fdd on eriknw:mask_and_or into ca75633 on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw eriknw mentioned this pull request Jul 6, 2022
Fill out the documentation #268
Merged
jim22k
jim22k reviewed Jul 7, 2022
View reviewed changes
Comment thread graphblas/mask.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
jim22k
jim22k approved these changes Jul 7, 2022
View reviewed changes

@jim22k jim22k left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks good, but the comments are technically wrong.

I think the recipe needs to be:

>>> val = Matrix(bool, nrows, ncols)
>>> val(mask1) << True
>>> val(mask2, replace=True) << val
>>> new_mask = val.S

The same recipe should be listed in the comments for `.new()` as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Fix recipe for mask "and"
7cd2fdd
@eriknw

eriknw commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

Updated docstrings. We came up with the same solution, which is a good sign.
jim22k reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jim22k
jim22k merged commit ef4b1ca into python-graphblas:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Advanced Notation

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eriknw @coveralls @jim22k
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.