GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update README.md by SultanOrazbayev · Pull Request #404 · python-graphblas/python-graphblas

Conversation

@SultanOrazbayev

@SultanOrazbayev SultanOrazbayev commented Mar 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adds Python version badges and description of optional dependencies in README.md.

Partially addresses #402

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@SultanOrazbayev
Update README.md
0de225c
Adds Python version badges
@coveralls

coveralls commented Mar 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Coverage Status

Coverage: 99.494% (+0.07%) from 99.425% when pulling 7d9452b on SultanOrazbayev:patch-6 into 673650d on python-graphblas:main.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SultanOrazbayev
Update README.md
561f8e2
optional dependencies copied from docs
@eriknw

eriknw commented Mar 10, 2023

Copy link
Copy Markdown
Member

LGTM, thanks @SultanOrazbayev.

We can close #402 if you add yourself to Maintainers (if you'd like, and up to you if you want to include your email). I like the discussion around "who is a maintainer" from a recent NetworkX meeting where the prevailing opinion was that "maintainer" means being an active maintainer, which means actively engaging in discussions, PRs, and/or creating PRs. You definitely qualify :) . Plus, you're already a member in the github org.

I think we should also include "Python-graphblas Contributors" in the authors section of pyproject.toml.

SultanOrazbayev reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SultanOrazbayev added 3 commits March 11, 2023 10:39
@SultanOrazbayev
Merge branch 'python-graphblas:main' into patch-6
6b9a774
@SultanOrazbayev
Update pyproject.toml
fe6a68a
@SultanOrazbayev
Update pyproject.toml
1ede759
Taken the list from https://github.com/python-graphblas/python-graphblas/graphs/contributors

excluded Dependabot, though not against robots in general.
@SultanOrazbayev

SultanOrazbayev commented Mar 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thank you, Erik!

re: contributor section
I couldn't find the name for @ParticularMiner , and then thought maybe it's OK to include just GitHub handles. That didn't work out. :/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SultanOrazbayev
Update pyproject.toml
7d9452b
Removed `contributors` (not a valid key for project description it seems):
```
contributors = [
    {GitHub_handle = "eriknw"},
    {GitHub_handle = "jim22k"},
    {GitHub_handle = "ParticularMiner"},
    {GitHub_handle = "SultanOrazbayev"},
    {GitHub_handle = "seibert"},
]
```
@eriknw
eriknw merged commit a0c152c into python-graphblas:main Mar 11, 2023
@eriknw

eriknw commented Mar 11, 2023

Copy link
Copy Markdown
Member

This is in, thanks @SultanOrazbayev (and welcome as a more-officially recognized maintainer)!

And, yeah, no need to include all the names or github handles of all the contributors under authors. The git log and github has a record of that, and the authorship shows up properly in Zenodo.

It's sad that ParticularMiner seems to have disappeared 8 months ago. I hope he's okay and simply too busy having fun ;)

SultanOrazbayev reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SultanOrazbayev
SultanOrazbayev deleted the patch-6 branch March 12, 2023 03:42
@eriknw eriknw mentioned this pull request May 8, 2023
Python-graphblas: high-performance sparse linear algebra for scalable graph analytics pyOpenSci/software-submission#81
Closed
11 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SultanOrazbayev @coveralls @eriknw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.