GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix infix expression `_value` and `_expr` usage by eriknw · Pull Request #418 · python-graphblas/python-graphblas

Conversation

@eriknw

@eriknw eriknw commented Mar 28, 2023

Copy link
Copy Markdown
Member

Previously, infixexpr._value was sometimes MatrixExpression and sometimes Matrix. Scary!

Fixes #416.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eriknw
Fix infix expression _value and _expr usage
ff1fcb5 
Previously, `infixexpr._value` was sometimes `MatrixExpression` and sometimes `Matrix`. Scary!
@eriknw
eriknw requested a review from jim22k March 28, 2023 16:00
@eriknw eriknw added the bug Something is broken label Mar 28, 2023
jim22k
jim22k approved these changes Mar 28, 2023
View reviewed changes
@coveralls

coveralls commented Mar 28, 2023

Copy link
Copy Markdown

Coverage Status

Coverage: 99.43% (-0.07%) from 99.499% when pulling ff1fcb5 on eriknw:fix416 into 0c1b102 on python-graphblas:main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eriknw
eriknw merged commit 41fb71a into python-graphblas:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jim22k jim22k jim22k approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug Something is broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_repr_html_ broken for m @ m.T

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eriknw @coveralls @jim22k
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.